Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsbackup should allow all valid DNS hostnames as host names #21

Closed
pm215 opened this issue Dec 5, 2014 · 1 comment
Closed

rsbackup should allow all valid DNS hostnames as host names #21

pm215 opened this issue Dec 5, 2014 · 1 comment
Labels
Milestone

Comments

@pm215
Copy link

@pm215 pm215 commented Dec 5, 2014

I have a machine I'm backing up whose hostname happens to contain hyphens ("cam-vm-266"). I did the obvious thing and used the hostname as the 'HOST' part of the host stanza:
root@e104462:~# cat /etc/rsbackup/hosts.d/cam-vm-266
host cam-vm-266
hostname cam-vm-266.mydomain.com
volume root /
exclude /tmp/*
exclude /var/lib/schroot/mount/*

and rsbackup complains:
root@e104462:~# rsbackup --backup --dry-run
ERROR: /etc/rsbackup/hosts.d/cam-vm-266:1: invalid host name

Removing all the 'hyphens' from the "host" line placates it, but it would be nice if the allowed character sets lined up.

@ewxrjk
Copy link
Owner

@ewxrjk ewxrjk commented Dec 31, 2014

Historically the reason for '-' being prohibited was the parsing of logfile names, which used that character as a separator.
In the next release these logfiles mostly don't exist. The one place they do exist is during upgrade from previous versions! But since previous versions can't have names with dashes in it shouldn't be possible to cause an ambiguous parse.
So I think this restriction can be loosened without risk in the next release.

@ewxrjk ewxrjk added this to the 2.0 milestone Dec 31, 2014
@ewxrjk ewxrjk closed this in 7323fce Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants