Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to backup volumes without compression #41

Closed
d1mertz1 opened this issue Dec 16, 2017 · 4 comments
Closed

Feature request: option to backup volumes without compression #41

d1mertz1 opened this issue Dec 16, 2017 · 4 comments
Labels
Milestone

Comments

@d1mertz1
Copy link

@d1mertz1 d1mertz1 commented Dec 16, 2017

I'd like to use rsbackup to backup a volume containing already compressed data (fotos and videos).
In that use case it does not make sense to use the "--compress" rsync option. Unfortunately it seems that this option is hardcoded and cannot be overriden easily.

It would be really usefull to have an option on volume level to suppress the "--compress" passed to rsync.

Thanks,
Denis

@ewxrjk ewxrjk added the feature label Dec 16, 2017
@ewxrjk ewxrjk added this to the 5.0 milestone Dec 16, 2017
@ewxrjk
Copy link
Owner

@ewxrjk ewxrjk commented Dec 16, 2017

This should be possible in the the next release, using the options added in 4a4b174.

@d1mertz1
Copy link
Author

@d1mertz1 d1mertz1 commented Dec 17, 2017

great :-)

i managed to build this from source (master) and i just tried it out.
It works on host level, but it does not on volume level.
But according to rsbackup(5) the new option rsync-base-options should be inheritable, so it should work on volume level as well ?

Anyway on host level this is already a big help

ewxrjk added a commit that referenced this issue Dec 17, 2017
@ewxrjk
Copy link
Owner

@ewxrjk ewxrjk commented Dec 17, 2017

Pull and try again l-)

@d1mertz1
Copy link
Author

@d1mertz1 d1mertz1 commented Dec 17, 2017

It works as expected now.

The issue can be closed.

Thanks !

@ewxrjk ewxrjk closed this Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants