Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsbackup causes cronmail with lots of WARNINGs and ERRORs if pruning is stopped due to prune-timeout setting #89

Closed
pm215 opened this issue Nov 28, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@pm215
Copy link

@pm215 pm215 commented Nov 28, 2020

If the prune-timeout setting is used to restrict the time spent pruning old backups, and rsbackup stops pruning in a particular run as a result, I get a big long cron barfmail like this:

/etc/cron.daily/rsbackup:
WARNING: action list timed out, killing subprocesses
WARNING: action list timed out, cancelling remove/mnementh/root/backup2/2020-10-31
WARNING: action list timed out, cancelling remove/mnementh/root/backup2/2020-11-02
WARNING: action list timed out, cancelling remove/mnementh/root/backup2/2020-11-03
WARNING: action list timed out, cancelling remove/mnementh/root/backup2/2020-11-04
WARNING: action list timed out, cancelling remove/orth/boot/backup2/2020-05-20
WARNING: action list timed out, cancelling remove/orth/boot/backup2/2020-05-21
WARNING: action list timed out, cancelling remove/orth/boot/backup2/2020-05-22
[etc etc etc]
WARNING: action list timed out, cancelling remove/orth/root/backup2/2020-11-03
WARNING: action list timed out, cancelling remove/orth/root/backup2/2020-11-04
ERROR: failed to remove /mnt/backup2/mnementh/root/2020-10-30: rm: Terminated
ERROR: failed to remove /mnt/backup2/mnementh/root/2020-10-31: cancelled
ERROR: failed to remove /mnt/backup2/mnementh/root/2020-11-02: cancelled
ERROR: failed to remove /mnt/backup2/mnementh/root/2020-11-04: cancelled
ERROR: failed to remove /mnt/backup2/mnementh/root/2020-11-03: cancelled
ERROR: failed to remove /mnt/backup2/orth/boot/2020-05-20: cancelled
ERROR: failed to remove /mnt/backup2/orth/boot/2020-05-21: cancelled
[etc etc etc]

Since "stopping pruning because the configuration says not to spend too much time pruning" is a normal expected action, it doesn't seem to me to merit a big long list of WARNINGS/ERRORS in cronmail (the format of which is rather long and not very informative). It might be nice to instead have a summary of the current pruning situation in the standard backup-report email ("%d stale backups still awaiting pruning" or something).

(In this case I have a big lot of pending prunes because I've just switched the backup volume from the default pruning policy, which kept 180 or so backups, to the 'decay' policy, whose tuning parameters mean that most of the old every-day backups are now set to be pruned.)

@ewxrjk ewxrjk added the usability label Nov 29, 2020
@ewxrjk ewxrjk added this to the 8.0 milestone Nov 29, 2020
@ewxrjk
Copy link
Owner

@ewxrjk ewxrjk commented Nov 29, 2020

Agreed, a single warning message (mentioning the reason for the timeout) would be plenty. Also:

warning(WARNING_DEPRECATED, "action list timed out, killing subprocesses");

...is obviously the wrong warning category.

@ewxrjk ewxrjk self-assigned this Dec 27, 2020
ewxrjk added a commit that referenced this issue Jan 1, 2021
Action & prune timeout errors are moved to WARNING_VERBOSE.

re #89
@ewxrjk
Copy link
Owner

@ewxrjk ewxrjk commented Jan 1, 2021

Would you be able to test the https://github.com/ewxrjk/rsbackup/tree/issue89 branch to see if it has better behaviour for you?

@pm215
Copy link
Author

@pm215 pm215 commented Jan 1, 2021

Not currently, unfortunately -- the backlog of things needing pruning has now been pruned and because i'm now using the decay prune policy there are many fewer backups on a disk at once, so I no longer have or expect to run into the "so many outstanding prune operations that they timeout" situation.

@ewxrjk ewxrjk closed this in f38766f Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants