-
Notifications
You must be signed in to change notification settings - Fork 0
#253: Made dependencies optional in file pyproject.toml
#254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ckunki
merged 27 commits into
main
from
refactoring/253-Made_dependencies_optional_in_file_pyproject.toml
Sep 11, 2025
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a3479ba
253: Made dependencies optional in file `pyproject.toml`
ckunki a3573c4
Removed section dependendencies
ckunki 20cf94e
Updated optional dependencies
ckunki a79ed7a
Install all optional dependencies also for lint
ckunki a910215
Removed commented-out lines
ckunki 4969974
made some dependencies mandatory
ckunki ab82233
Used poetry 2.0 syntax for mandatory dependencies
ckunki 8d3b092
poetry lock
ckunki 2abb51e
Fixed review findings
ckunki f33701d
Update doc/user_guide/user-guide.md
ckunki fc71b75
Added a list of all NC's dependency categories to the User Guide
ckunki c7e324b
Added brief explanations and links to pypi for all extra categories
ckunki ea9c670
Added link to SLC documentation
ckunki a054ecd
Fixed table formatting in User Guide
ckunki 0c470c0
Renamed extra "itde" to "docker-db"
ckunki 2c9c196
updated sample usage of extra "itde"
ckunki 0d0c9f0
Updated description of category docker-db in optional dependencies
ckunki c51cb17
Removed old table with column pypi
ckunki a6cd96d
relocked dependencies
ckunki 14d8923
Added optional dependency for integration tests with external ITDE
ckunki 15affba
Run ordinary itests without confirmation
ckunki 9df20ba
Added optional dependency for integration tests with external ITDE (2)
ckunki 01c5e25
Added optional dependency for itests with external ITDE (3)
ckunki fe9f021
Added optional dependency for itests with external ITDE (3)
ckunki a448166
Added optional dependency for itests with external ITDE (3)
ckunki 9533edd
Added optional dependency for itests with external ITDE (3)
ckunki d3cdead
Re-enabled precondition slow test approval for ordinary-itests
ckunki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,9 @@ | ||
| # Unreleased | ||
|
|
||
| ## Summary | ||
|
|
||
| This release marks most of the NC's dependencies in file `pyproject.toml` as _optional_. Please see updated installation instructions in the NC User Guide. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also not completely true anymore
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please explain! |
||
|
|
||
| ## Refactorings | ||
|
|
||
| * #253: Made dependencies optional in file `pyproject.toml` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTB currently only offers action
python-environmentto be called with a list of space-separated extras.Proposal: Add support for requesting to install "all extras".