Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1102] Update Excalibur to follow style guidelines #1124

Merged
merged 6 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@DavidLi119
Copy link
Contributor

commented Apr 15, 2019

Changed var to let and const.
Works on issue #1102
Files changed: src/spec/AnimationSpec.ts and src/spec/BoundingBoxSpec.ts
===馃搵 PR Checklist 馃搵===

  • 馃搶 issue exists in github for these changes
  • 馃敩 existing tests still pass
  • 馃檲 code conforms to the style guide
  • 馃搻 new tests written and passing / old tests updated with new scenario(s)
  • 馃搫 changelog entry added (or not needed)

==================

DavidLi119 added some commits Apr 13, 2019

Update Excalubur to follow style guidelines
Changed `var` to `const` and `let` where applicable. Left `var` in `for` loops alone
changed `var` to `const/let`
Files AnimationSpec.ts and BoundingBoxSpec.ts have been updated to use `const` and `let` instead of `var`

@eonarheim eonarheim changed the title Update Excalibur to follow style guidelines [#1102] Update Excalibur to follow style guidelines Apr 15, 2019

@eonarheim eonarheim added this to the 0.23.0 Release milestone Apr 15, 2019

@eonarheim
Copy link
Member

left a comment

LGTM 馃殺

@eonarheim eonarheim merged commit 7e56667 into excaliburjs:master Apr 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.288%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.