Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode #106

Merged
merged 8 commits into from Jun 8, 2021
Merged

Support dark mode #106

merged 8 commits into from Jun 8, 2021

Conversation

h7y
Copy link
Member

@h7y h7y commented May 25, 2021

#85

I'll also raise a PR in excalidraw to pass the theme

@vercel
Copy link

vercel bot commented May 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-libraries/hnatFmDJ2cdE1nCjDWi6KTvne3Yx
✅ Preview: https://excalidraw-libraries-git-fork-h7y-add-dark-mode-excalidraw.vercel.app

@dwelle
Copy link
Member

dwelle commented May 25, 2021

Thanks! Unfortunately there's an outstanding issue I haven't had time yet to look into which prevents builds right now :(.

script.js Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Jun 5, 2021

Works great!

script.js Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Jun 8, 2021

I moved the initialization out from the fetching completely for best UX. If everything looks good, we can merge!

index.html Outdated Show resolved Hide resolved
script.js Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Jun 8, 2021

Changed themes to use icons and moved into navbar.

Copy link
Member

@ad1992 ad1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets ship 🎉

@dwelle dwelle merged commit 753add3 into excalidraw:main Jun 8, 2021
@h7y h7y deleted the add-dark-mode branch June 9, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants