Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separators on context menu #2506

Closed
alexlazovic opened this issue Dec 11, 2020 · 9 comments · Fixed by #2659
Closed

Add separators on context menu #2506

alexlazovic opened this issue Dec 11, 2020 · 9 comments · Fixed by #2659
Assignees
@Kartik1397
Labels
enhancement New feature or request UX/UI User-experience/interface issue

Comments

@alexlazovic
Copy link

We could add the separators here to help the user scan more easily through the options. Also, if possible, push the "Delete" option to the bottom and make it red to clearly communicate a destructive operation.

Context Menu
@lipis
Copy link
Member

lipis commented Dec 11, 2020

We also have these ones:

Screenshot 2020-12-11 at 7 15 54 PM

Screenshot 2020-12-11 at 7 15 42 PM

@dwelle
Copy link
Member

dwelle commented Dec 11, 2020

Looks good. Agreed on the delete.

@lipis lipis added enhancement New feature or request UX/UI User-experience/interface issue labels Dec 11, 2020
@vjeux
Copy link
Contributor

vjeux commented Dec 11, 2020

That looks great, thanks for helping out. If someone is interested in implementing this, that'd be awesome.

@dwelle

This comment has been minimized.

Sign in to view
@lipis lipis mentioned this issue Dec 12, 2020
Closed
@lipis lipis pinned this issue Dec 14, 2020
@kbariotis kbariotis unpinned this issue Dec 19, 2020
@kbariotis kbariotis pinned this issue Dec 20, 2020
@Kartik1397
Copy link
Contributor

Can I work on this?

@lipis
Copy link
Member

lipis commented Dec 21, 2020

Please do!

@kbariotis
Copy link
Contributor

Go for it @Kartik1397, the main component for the context menu is this one and is being called primarily from the App like here.

@lipis
Copy link
Member

lipis commented Dec 22, 2020

@Kartik1397 If you're working on it.. create an early draft so we can test/review early if there are choices to be made :)

@Kartik1397
Copy link
Contributor

Sure @lipis, I will open [WIP] PR as soon as I make some progress.

@dwelle dwelle mentioned this issue Dec 22, 2020
Merged
@lipis lipis unpinned this issue Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kartik1397 Kartik1397

Labels
enhancement New feature or request UX/UI User-experience/interface issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add separators on context menu Kartik1397/excalidraw
6 participants
@lipis @vjeux @kbariotis @dwelle @alexlazovic @Kartik1397