Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
It seems that #510 broke CodeSandbox (it works on the preceding commit).
Haven't investigated further, so not sure what exactly is the problem.
The text was updated successfully, but these errors were encountered:
I'm very sorry 😔. I just cloned and deployed on Glitch, and there it works fine (apart from an unrelated ws:// mixed content error when loaded over https).
I'm not sure what CodeSandbox does differently. Does anyone know how to debug?
Sorry, something went wrong.
OK, I traced this down. In browser-nativefs, I use a dynamic import to load either the legacy file handling approach, or the Native File System API (deep link).
If you look at the deployed version, this is the source tree (note the presence of file-save-nativefs.mjs and file-open-nativefs.mjs):
If you compare to CodeSandbox's version, the dynamically imported files are missing:
I will open an Issue with CodeSandbox.
Update: this is a known issue with CodeSandbox: codesandbox/codesandbox-client#1887.
Mhm... I'm not sure if the dynamic import itself is the problem, because I've manually tried it out and it works (check https://codesandbox.io/s/floral-lake-ou5wi index.tsx:201).
It may be a problem with CodeSandbox & dynamically importing/resolving mjs files, or it may be connected with CodeSandbox & Create-react-app bundler integration issues (which there were many).
Another theory is that it's codesandbox/codesandbox-client#1774.
That's feels more like it 👍.
This successfully loads in CodeSandbox after #523 was merged, but now the file opening/saving is broken and throws a console error. It works on Excalidraw.com. ¯\(ツ)/¯
As I understand, it only throws on CSB? IMO that's an acceptable compromise (/cc @vjeux), as CSB will be used only for quick & dirty development.
I'll close this for now. Let's see if anyone comes to complain :).
Thanks for working on this!
No branches or pull requests