Skip to content

Proper RTL support#1154

Merged
j-f1 merged 6 commits into
masterfrom
arabic
Apr 2, 2020
Merged

Proper RTL support#1154
j-f1 merged 6 commits into
masterfrom
arabic

Conversation

@j-f1

@j-f1 j-f1 commented Apr 1, 2020

Copy link
Copy Markdown
Member

Will rebase on master once #1151 is merged.

@vercel

vercel Bot commented Apr 1, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/excalidraw-team/excalidraw/9rl2729ok
✅ Preview: https://excalidraw-git-arabic.excalidraw-team.now.sh

@lipis

lipis commented Apr 1, 2020

Copy link
Copy Markdown
Member

WOW! That was fast :)

@lipis

lipis commented Apr 1, 2020

Copy link
Copy Markdown
Member

#1151 is ready.. merge it whenever you want! Has 100% of Arabic in it..

@lipis lipis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fun to use it :) Didn't find any obvious issues..

@j-f1 j-f1 linked an issue Apr 1, 2020 that may be closed by this pull request
@vjeux

vjeux commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

Can you put a screenshot?

@j-f1

j-f1 commented Apr 1, 2020

Copy link
Copy Markdown
Member Author

@mohammadameer Can you check out the preview and tell me if you see anything that looks wrong?

@lipis

lipis commented Apr 1, 2020

Copy link
Copy Markdown
Member

Screenshot 2020-04-01 at 9 06 37 PM


Screenshot 2020-04-01 at 9 06 49 PM

@j-f1

j-f1 commented Apr 1, 2020

Copy link
Copy Markdown
Member Author

Screen Shot 2020-04-01 at 14 05 13

@vjeux

vjeux commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

Nice! Looks like the pointer should not be shifted :) Not sure if undo/redo makes sense shifted or not.

@j-f1 j-f1 merged commit 6635261 into master Apr 2, 2020
@j-f1 j-f1 deleted the arabic branch April 2, 2020 16:21
TusharSariya pushed a commit to TusharSariya/excalidraw-tf that referenced this pull request May 27, 2026
* Add RTL styles. Most of the work is done by the browser 💖

* Refactor getLanguage

* Additional fixes

* Mirror the mouse pointer icon

* Move the vertical scrollbar to the left on RTL

* Revert "Mirror the mouse pointer icon"

This reverts commit f69b132.
NavarroYahir pushed a commit to ludensproductions/excalidraw that referenced this pull request Jun 3, 2026
* Add RTL styles. Most of the work is done by the browser 💖

* Refactor getLanguage

* Additional fixes

* Mirror the mouse pointer icon

* Move the vertical scrollbar to the left on RTL

* Revert "Mirror the mouse pointer icon"

This reverts commit f69b132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i want to add arabic

3 participants