Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper RTL support #1154

Merged
merged 6 commits into from
Apr 2, 2020
Merged

Proper RTL support #1154

merged 6 commits into from
Apr 2, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Apr 1, 2020

Will rebase on master once #1151 is merged.

@vercel
Copy link

vercel bot commented Apr 1, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/excalidraw-team/excalidraw/9rl2729ok
✅ Preview: https://excalidraw-git-arabic.excalidraw-team.now.sh

@lipis
Copy link
Member

lipis commented Apr 1, 2020

WOW! That was fast :)

@lipis
Copy link
Member

lipis commented Apr 1, 2020

#1151 is ready.. merge it whenever you want! Has 100% of Arabic in it..

Copy link
Member

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fun to use it :) Didn't find any obvious issues..

@j-f1 j-f1 linked an issue Apr 1, 2020 that may be closed by this pull request
@vjeux
Copy link
Contributor

vjeux commented Apr 1, 2020

Can you put a screenshot?

@j-f1
Copy link
Member Author

j-f1 commented Apr 1, 2020

@mohammadameer Can you check out the preview and tell me if you see anything that looks wrong?

@lipis
Copy link
Member

lipis commented Apr 1, 2020

Screenshot 2020-04-01 at 9 06 37 PM


Screenshot 2020-04-01 at 9 06 49 PM

@j-f1
Copy link
Member Author

j-f1 commented Apr 1, 2020

Screen Shot 2020-04-01 at 14 05 13

@vjeux
Copy link
Contributor

vjeux commented Apr 1, 2020

Nice! Looks like the pointer should not be shifted :) Not sure if undo/redo makes sense shifted or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i want to add arabic
3 participants