New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excalicharts MVP #1723
Excalicharts MVP #1723
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/8qvtuj446 |
@dwelle I think in that case they are both treated as numbers |
But it should use 1st columns for X axis. |
Co-authored-by: David Luzar <luzar.david@gmail.com>
ah that bug came from a last minute decision to remove a specific list of currency symbols. i added it back in -- it's just a kind of random selection of currency symbols I threw in there. is there a more official list we should use? regardless, it might be ok to roll with this for now and fix it in a follow up since it's not super discoverable in this form anyway. alternatively, we could remove support for currencies as numbers. |
No idea, but it also won't be as simple as that because not every currency puts the symbol before the number. But like you said, let's not overengineer it right now. It's pretty solid as it is! |
In France you put the euro symbol -after- the number for example :) |
What I would do is to try and parse the number and ignore everything else. Also in French you use comma for decimals rather than dots. |
Copy some cells from excel, paste them into excalidraw, and get an editable bar chart.
In the future we may want to add something to the toolbar or more chart types. This is an MVP optimized for a small implementation size and for making Excalidraw an option for creating presentations.