Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excalicharts MVP #1723

Merged
merged 4 commits into from Jun 6, 2020
Merged

Excalicharts MVP #1723

merged 4 commits into from Jun 6, 2020

Conversation

petehunt
Copy link
Collaborator

@petehunt petehunt commented Jun 6, 2020

Copy some cells from excel, paste them into excalidraw, and get an editable bar chart.

In the future we may want to add something to the toolbar or more chart types. This is an MVP optimized for a small implementation size and for making Excalidraw an option for creating presentations.

Screen Shot 2020-06-05 at 11 33 45 AM

@vercel
Copy link

vercel bot commented Jun 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/8qvtuj446
✅ Preview: https://excalidraw-git-fork-petehunt-excalicharts-mvp.excalidraw.now.sh

@dwelle
Copy link
Member

dwelle commented Jun 6, 2020

Shouldn't the x/y axis be reversed? Let's say I have this data:

date	amount
2020-06-06	1
2020-06-07	23
2020-06-08	2
2020-06-09	4
2020-06-10	33
2020-06-11	42
2020-06-12	12
2020-06-13	34

it creates:

image

src/charts.ts Outdated Show resolved Hide resolved
@lipis
Copy link
Member

lipis commented Jun 6, 2020

@dwelle I think in that case they are both treated as numbers

@dwelle
Copy link
Member

dwelle commented Jun 6, 2020

@dwelle I think in that case they are both treated as numbers

But it should use 1st columns for X axis.

Co-authored-by: David Luzar <luzar.david@gmail.com>
@petehunt
Copy link
Collaborator Author

petehunt commented Jun 6, 2020

ah that bug came from a last minute decision to remove a specific list of currency symbols. i added it back in -- it's just a kind of random selection of currency symbols I threw in there. is there a more official list we should use?

regardless, it might be ok to roll with this for now and fix it in a follow up since it's not super discoverable in this form anyway. alternatively, we could remove support for currencies as numbers.

@dwelle
Copy link
Member

dwelle commented Jun 6, 2020

it's just a kind of random selection of currency symbols I threw in there. is there a more official list we should use?

No idea, but it also won't be as simple as that because not every currency puts the symbol before the number.

But like you said, let's not overengineer it right now. It's pretty solid as it is!

@dwelle dwelle merged commit f7c4efb into excalidraw:master Jun 6, 2020
@vjeux
Copy link
Contributor

vjeux commented Jun 6, 2020

In France you put the euro symbol -after- the number for example :)

@vjeux
Copy link
Contributor

vjeux commented Jun 6, 2020

What I would do is to try and parse the number and ignore everything else. Also in French you use comma for decimals rather than dots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants