-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export types for package @excalidraw/excalidraw 🎉 #3337
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/4abcsnKdnjQbFfMNmiFEkyjdoK7B |
27 of them can be resolved by including |
It will start including the other folders also for example |
Then let's make the |
That also works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's ship it! 🎉
The output is kinda sad — this microsoft/TypeScript#4433 should help, but it'll probably take years to get done :). Though someone made a rollup plugin to accomplish it more or less: microsoft/TypeScript#4433 (comment) — for other time, though. |
Yep will try it out in next PR, also we might wanna publish the types under |
Awesome! Thanks for this @ad1992 |
fixes #2514
pushed here
excalidraw-app
types are shared with core hence getting added, fix it so it doesn't get added.