fix: rewrite collab element reconciliation to fix z-index issues#4076
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/C6XmK9yCUj4W3V2K3D2i4aNkWDFH |
dwelle
force-pushed
the
rewrite_reconciler
branch
from
c893139 to
9dc4007
Compare
ad1992
reviewed
Oct 21, 2021
dwelle
force-pushed
the
rewrite_reconciler
branch
from
fa01724 to
1c69d74
Compare
ad1992
reviewed
Oct 27, 2021
Member
ad1992
left a comment
ad1992
left a comment
There was a problem hiding this comment.
looks good and tests are super helpful 💯
ad1992
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1376
This is a port from E+. The algo isn't super well written (there are several array reindexing), but it's fast enough — in worst cases (syncing ~1500+ elements) it's a couple of ms.
It works by annotating synced elements with their "parents" so that we know where in the array we should insert them.
Unclear how the algo will hold up in 3+ user rooms.