Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow publishing libraries from UI #4115

Merged
merged 120 commits into from
Nov 17, 2021
Merged

feat: Allow publishing libraries from UI #4115

merged 120 commits into from
Nov 17, 2021

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Oct 29, 2021

  • Backend support
  • Support publishing of libraries
  • Don't allow publishing of installed libraries unless edited
  • Support multiple libraries deletion and publish
  • Don't allow publishing same library twice
  • Fix the layout shift when hovering
  • Fix the layout shift when publish/delete buttons rendered
  • local storage migration
  • Remove //@ts-ignore
  • Fix tests
  • Support twitter handle and make github username optional
  • Use github handle | twitter handle | first name when building the filepath for PR instead of github handle
  • Add optional website field
  • Use website | github url | twitter url for author's url field in libraries
  • Check why fetch isn't working with form onSubmit so we can use html5 validation else set up validation for required fields

Good to have

  • Improve png generation for multiple libs eg here
    Done: here
  • Try showing username in the pr description, done here
  • Make checkbox background opaque so its noticeable
  • Add placeholders in publish dialog
  • Show selected items preview in publish dialog
  • Rename library to libraryItem in .excalidrawLib and add migration
  • Don't close publish dialog on click outside
  • Show selected library actions only when library item selected and use icons instead
  • Add edit name functionality and error validation
  • Add twitter/github urls in libraries.json when PR is created
  • Save publish library data to local storage and clear once published
  • Support export for selected library items and update export icon
  • support removing items to be published (→ UI within the dialog)
  • Replace window.confirm alerts for removal lib with confirm dialog

future

  • we should have a bounding box of fixed width/height and resize the libs to that size so it fits inside the bounding box, so that png looks nicer
  • persist publish dialog state to LS on reload (We persist when dialog closes right now, well, technically just persist on change, debounced, so it's futureproof)

@vercel
Copy link

vercel bot commented Oct 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/CeG6UKBDaznAgkk6VMK47r38Duz6
✅ Preview: https://excalidraw-git-aakansha-libraries-excalidraw.vercel.app

@ad1992 ad1992 merged commit 84d1d99 into master Nov 17, 2021
@ad1992 ad1992 deleted the aakansha-libraries branch November 17, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants