More mobile tweaks

[j-f1]

Ref #138

• language selector
• remove lock button on mobile

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/vjeux/excalidraw/ih9g0u3t1
✅ Preview: https://excalidraw-git-more-tweaks.vjeux.now.sh

[vjeux]

The done button for drawing arrows seems to be off by one. It only shows after you have added three points instead of two. When you confirm, it drops the last segment of the arrow

[vjeux]

There’s a small jump while dragging elements

• dezoom to the maximum (to make it more obvious)
• create a circle
• touch down on the edge with one finger
• move by one or two pixels
• the circle jumps to more than a few pixels
• move by one or two more pixels
• the circle properly tracks your finger

Usually when I see this kind of bugs, it’s an issue where we don’t keep track of the offset where the element was started being dragged and instead we use the center.

[vjeux]

(Just to be clear, I’m just posting here all the things I’m seeing around mobile support, they are not required to be addressed in this PR)

[j-f1]

There is no longer an edit icon to toggle it off

Fixed.

The done button for drawing arrows seems to be off by one. [...] When you confirm, it drops the last segment of the arrow

If you use the mouse to click two segments, then move to a third point without clicking, then hit enter, you’ll see the same thing. Not sure how to resolve it.

[dwelle]

The done button for drawing arrows seems to be off by one. [...] When you confirm, it drops the last segment of the arrow

If you use the mouse to click two segments, then move to a third point without clicking, then hit enter, you’ll see the same thing. Not sure how to resolve it.

That's a different thing with the mouse. The last point isn't committed yet, so it's correct that upon confirm it's discarded.

[j-f1]

actionFinalize removes the last point from the multi-point object it’s passed. This is because when you click with a mouse, another segment is automatically added that follows the cursor. How can I reconcile these two behaviors?

[dwelle]

I guess conditionally remove the last point only if not on mobile.

[j-f1]

I’m also thinking of cases like Windows laptops where you might lay points down with a mouse or touch.

[j-f1]

I think the best option would be to record the pointer the most recent point was laid down with and only remove it if the pointer is a mouse. How would I store that so the finalize action can access it but it isn’t permanently stored in the document?

[j-f1]

There’s a small jump while dragging elements

I can’t reproduce this on an iPhone 8 or simulated iPhone 11.

[dwelle]

I think the best option would be to record the pointer the most recent point was laid down with and only remove it if the pointer is a mouse. How would I store that so the finalize action can access it but it isn’t permanently stored in the document?

I haven't checked the code. Yes, the best way is to identify whether you're in the created-temp-arrow-point mode and act on that.

[j-f1]

This might also be related to the fact that tapping once to start a line actually creates two points.

[vjeux]

Is this in a state to be merged in? If yes, we should probably do it and continue support in a follow up.

[lipis]

Strange focus border when tapping on hamburger menu on Pixel 4..

[j-f1]

@lipis Weird — I can’t repro on iOS. I’ll try to use an Android emulator in the future, but I suspect it’ll be fixed by switching those buttons to be radio buttons, which I plan to do as part of a future refactor.

[j-f1]

Good to go @vjeux — I moved the incomplete tasks back to the issue.

[vjeux]

I disagree that the mobile UI should have less features because it’s on a phone. I use the lock icon a lot when drawing shapes with a bunch of lines. I wish we didn’t totally remove it as it’s useful.

I’m happy for it being behind a menu.