Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update border-xform.js #184

Merged
merged 1 commit into from Oct 7, 2016

Conversation

@skumarnk2
Copy link
Contributor

commented Sep 16, 2016

i was getting below error in simple read of excel file. after changes i was able to read the file:

D:\IZ3.0\Code\DataLoader\node_modules\exceljs\lib\xlsx\xform\style\border-xform.
js:101
this.model.color = this.map.color.model;
^

TypeError: Cannot set property 'color' of undefined
at utils.inherits.parseClose (D:\IZ3.0\Code\DataLoader\node_modules\exceljs
lib\xlsx\xform\style\border-xform.js:101:28)
at utils.inherits.parseClose (D:\IZ3.0\Code\DataLoader\node_modules\exceljs
lib\xlsx\xform\style\border-xform.js:198:24)
at utils.inherits.parseClose (D:\IZ3.0\Code\DataLoader\node_modules\exceljs
lib\xlsx\xform\list-xform.js:90:24)
at utils.inherits.parseClose (D:\IZ3.0\Code\DataLoader\node_modules\exceljs
lib\xlsx\xform\style\styles-xform.js:222:24)
at SAXStream. (D:\IZ3.0\Code\DataLoader\node_modules\exceljs\lib
xlsx\xform\base-xform.js:71:19)
at emitOne (events.js:77:13)
at SAXStream.emit (events.js:169:7)
at Object.me._parser.(anonymous function) [as onclosetag](D:IZ3.0CodeDat
aLoadernode_modulesexceljsnode_modulessaxlibsax.js:245:15)
at emit (D:\IZ3.0\Code\DataLoader\node_modules\exceljs\node_modules\sax\lib
sax.js:615:33)
at emitNode (D:\IZ3.0\Code\DataLoader\node_modules\exceljs\node_modules\sax
lib\sax.js:620:3)
at closeTag (D:\IZ3.0\Code\DataLoader\node_modules\exceljs\node_modules\sax
lib\sax.js:861:5)
at Object.write (D:\IZ3.0\Code\DataLoader\node_modules\exceljs\node_modules
sax\lib\sax.js:1182:11)
at SAXStream.write (D:\IZ3.0\Code\DataLoader\node_modules\exceljs\node_modul
es\sax\lib\sax.js:227:16)
at Entry.ondata (_stream_readable.js:542:20)
at emitOne (events.js:77:13)
at Entry.emit (events.js:169:7)

@tkirda

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2016

Have the same issue and this change makes it go away.

@guyonroche Could you please merge and release an update. Thanks, great library!

@guyonroche guyonroche merged commit 653630c into exceljs:master Oct 7, 2016
@skumarnk2 skumarnk2 deleted the skumarnk2:patch-1 branch Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.