Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #163: the "spans" attribute of the row element is optional #203

Merged
merged 1 commit into from Oct 24, 2016

Conversation

@arturas-vitkauskas
Copy link

commented Oct 20, 2016

The "spans" attribute is not required in the "row" element. Source of information: https://msdn.microsoft.com/en-us/library/office/documentformat.openxml.spreadsheet.row.aspx

If we create a Google Sheets spreadsheet and download it as XLSX, then the "spans" attributes do not appear in the "row" elements of the worksheet.

Attached is a test xlsx file, which causes the "Cannot read property 'split' of undefined" error when trying to read it with the exceljs package.
test-issue-163.xlsx

@tkirda

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2016

Looks good, waiting for the merge and NPM publish.

@guyonroche guyonroche merged commit 400305d into exceljs:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.