Skip to content
This repository was archived by the owner on Mar 6, 2023. It is now read-only.

Conversation

@caesay
Copy link
Contributor

@caesay caesay commented Apr 4, 2017

This fixed 99% of the annoyances I was having with heights jittering while watching recent event feeds. It works by briefly setting the overflow and white-space css properties in the initial render so the text will not wrap and effect the height. After the first truncate these properties are reset.

Note that it is actually a requirement that we reset the properties before we truncate, because trunk8 internally only looks at the height of an element to determine whether to truncate it or not.

Also note that truncating immediately on the initial render does not work because (presumably) the initial render of the DOM has not finished yet and trunk8 can not determine where to trim it.

Closes #130

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2017

CLA assistant check
All committers have signed the CLA.

@caesay caesay mentioned this pull request Apr 4, 2017
@niemyjski niemyjski merged commit 6df3f7b into exceptionless:master Apr 5, 2017
@niemyjski
Copy link
Member

Thanks for the PR! I was able to reproduce it by submitting an event with a really really long identity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Truncate rendering delay

3 participants