This repository was archived by the owner on Mar 6, 2023. It is now read-only.
Fix for height jitters when truncating single lines #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed 99% of the annoyances I was having with heights jittering while watching recent event feeds. It works by briefly setting the
overflowandwhite-spacecss properties in the initial render so the text will not wrap and effect the height. After the first truncate these properties are reset.Note that it is actually a requirement that we reset the properties before we truncate, because
trunk8internally only looks at the height of an element to determine whether to truncate it or not.Also note that truncating immediately on the initial render does not work because (presumably) the initial render of the DOM has not finished yet and
trunk8can not determine where to trim it.Closes #130