Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre Support IIDX Premium Controller #101

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Pre Support IIDX Premium Controller #101

merged 3 commits into from
Oct 31, 2017

Conversation

SackMagiclight
Copy link
Contributor

@SackMagiclight SackMagiclight commented Oct 30, 2017 •
edited
Loading

Twitter: @sack_magiclight

  • IIDX プレミアムコントローラーに対応
  • analog controller 設定を Trueでロジック切り替え
  • グローバルコンフィグを利用するため、一部クラスのコンストラクタ引数を変更しています
  • TODO(積み残し)
    • コントローラ毎の設定：現状異なる皿ロジックのDPが不可能(ex: プレコン+専コンコンバーター)
    • IIDXプレコンを認識して自動的にロジック制御->おそらくこっちのほうがスマート
  • 数曲プレイして問題ないかなーレベルの検証です。
    • 超絶技巧練習曲第一番「新世界」(N) ALLSCR : BPM193-16分皿 OK
    • After Burner[HYPER] : 皿LN , 皿絡み OK

ロジック参考：IIDX プレミアムコントローラ（専コン）をLR2で動かす

  • Support IIDX Premium Controller.
  • If use IIDX Premium Controller , analog controller is True(Global Config).
  • I modified the constructor to use Global Config.
  • TODO(FIX IT)
    • Currently different DP of scratch logic is impossible. (ex: IIDX Premium Controller + Other controller)
    • Automatic Scratch logic control if IIDX Premium Controller. -> better.
  • Tested, a few songs.
    • 超絶技巧練習曲第一番「新世界」(N) ALLSCR : BPM193-1/16 musical note Scratch -> OK
    • After Burner[HYPER] : Scratch LN , Scratch+Keys -> OK

Loggic Reference : IIDX プレミアムコントローラ（専コン）をLR2で動かす(Japanese)

@SackMagiclight
皿動作判定をプレコン仕様に暫定対応
9bf68da 
***
fix Scratch, for iidx premium controller
@SackMagiclight
configからの切り替え対応
81bd4c4 
TODO:コントローラ毎に設定する
***
set analog scratch value from config

TODO:controller unit
@SackMagiclight
BMControllerInputProcessorで読んだconfigを利用するように修正
35a749e 
***
fix read config at BMControllerInputProcessor
@exch-bms2 exch-bms2 merged commit f7b1c1c into exch-bms2:release0.5.1 Oct 31, 2017
exch-bms2 added a commit that referenced this pull request Nov 1, 2017
@exch-bms2
Merge pull request #101 from SackMagiclight/support_iidx_premium_cont…
6b83d93 
…roller
@exch-bms2 exch-bms2 mentioned this pull request Nov 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SackMagiclight @exch-bms2