New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Body and BodyParts APIs #1238
Comments
New API:
|
I'm seeing that the Content-Disposition header is not set correctly unless you specify |
Yep, that's intended. Form multipart is not the only use case for multipart. For example, some people use Gatling for SOAP MTOM, where Content-Disposition is not expected. |
👍 |
So, working fine? |
Like a charm! On Wed, Jun 26, 2013 at 8:23 AM, Stephane Landelle
|
Just another comment. It is not very obvious (at least to me) that to make the |
Don't know yet. I'm afraid that would bring more confusion. The first thing we'll do when we'll release Gatling 2 is to properly document everything. |
I was trying to follow the documentation examples on json bodies and it took me a long while to realize how the API had changed, since the specific part on the wiki about the body in the request is outdated. I only got it to work when i found this issue. Since i am new in github i dont know if its possible to suggest edits on wiki pages. If so i would be more than happy to update the body parameters section to reflect these changes. |
Except for the Gatling 2 page, the whole wiki targets Gatling 1 (Gatling 2 is still in milestone phase). Github can't display multiple versions of the same page. We'll migrate the documentation out of Github's wiki in a next version. |
See here: https://github.com/excilys/gatling/wiki/Gatling-2#wiki-bodies The link is in bold, in the top part of the right menu, can't do better for now. |
Yeah, i ended up getting to that Gatling 2 page and it answered all my questions. It was my mistake, i thought the documentation was already referring to Gatling 2. Thanks for the quick reply |
Problems with Body and BodyPart current APIs:
transferEncoding
andfileName
(for Content-Disposition header)=> Let's have one single method that explicitly takes different types. Have those types propose a builder pattern for non Scala users who are not familiar with Option and case classes copy
The text was updated successfully, but these errors were encountered: