Pass in client side certs and keys in pem format #234

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@ehowe
Contributor
ehowe commented May 28, 2013

The client side certs and their associated private keys can currently only be read in as a file path. Added support for passing it in as a PEM encoded string. To prevent the private key from being read out of memory, this data is then dumped into a Tempfile and then read back out, similar to the way it is done currently. Also added tests to ensure this works properly.

@geemus
Contributor
geemus commented May 29, 2013

@ehowe I'm not sure I understand the need for this. It adds a lot of complexity and the values would still be in memory in the hash, regardless of writing out to the files. Also, couldn't you just write the tempfiles outside excon and pass them in, instead of excon needing to be concerned about it? Sorry if I'm missing the point, it just is not super clear to me what we are gaining here I guess. Thanks!

@thommahoney
Contributor

Opened a new pull here: #236

@geemus
Contributor
geemus commented Jun 11, 2013

closing in favor of #236

@geemus geemus closed this Jun 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment