accept certificate and private_key data directly
Added certificate and private_key to valid connection keys
I'm afraid I still don't understand the need for this. It adds a lot of complexity and the values would still be in memory in the hash, regardless of writing out to the files. Also, couldn't you just write the tempfiles outside excon and pass them in, instead of excon needing to be concerned about it? Sorry if I'm missing the point, it just is not super clear to me what we are gaining here I guess. Thanks!
This does not write any new files. It changes the API so that you can pass the certificate data as strings instead of as file names. Existing behavior is preserved by default.
@thommahoney - got it. It seemed like in the initial pull there was concern about keeping the keys in memory, should we still worry about that?
No, as you said that have to be in memory at some point. Thanks for taking the time on this.
@thommahoney - does this need a release?