Accept certificate and private_key as strings #236

Merged
merged 2 commits into from Jun 12, 2013

Projects

None yet

4 participants

@lanej
lanej commented Jun 11, 2013
  • make certificate_path and private_key_path explicitly relate to filenames
  • maintains existing API client_cert and client_key options
@geemus
Contributor
geemus commented Jun 11, 2013

I'm afraid I still don't understand the need for this. It adds a lot of complexity and the values would still be in memory in the hash, regardless of writing out to the files. Also, couldn't you just write the tempfiles outside excon and pass them in, instead of excon needing to be concerned about it? Sorry if I'm missing the point, it just is not super clear to me what we are gaining here I guess. Thanks!

@thommahoney
Contributor

This does not write any new files. It changes the API so that you can pass the certificate data as strings instead of as file names. Existing behavior is preserved by default.

@geemus
Contributor
geemus commented Jun 12, 2013

@thommahoney - got it. It seemed like in the initial pull there was concern about keeping the keys in memory, should we still worry about that?

@thommahoney
Contributor

No, as you said that have to be in memory at some point. Thanks for taking the time on this.

@geemus geemus merged commit 771e573 into excon:master Jun 12, 2013

1 check passed

default The Travis CI build passed
Details
@geemus
Contributor
geemus commented Jun 12, 2013

Thanks!

@thommahoney - does this need a release?

@lanej
lanej commented Jun 12, 2013

yes please

@geemus
Contributor
geemus commented Jun 12, 2013

Done. 0.24.0

@lanej lanej referenced this pull request in lostisland/faraday Jul 17, 2013
Merged

[excon] pass client side cert information to excon #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment