Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip-address handling to no_proxy-envvar #718

Merged
merged 2 commits into from Jun 9, 2020

Conversation

@m-bucher
Copy link
Contributor

m-bucher commented Jun 4, 2020

I did add handling for host IP-addresses. This should also give the ability to specify network-addreses like 10.0.0.0/8 or [fc00::/7]in the no_proxy variable.
However, they will only be evaluated correctly if the requested URI also includes the IP-address.

Added an IPv4 and IPv6 address to the no_proxy variable in the tests, so they will fail, if this breaks again.
Maybe additional test-cases are needed regarding the no_proxy handling like

  • IP-address (maybe IP network-address)
  • no_proxy entries with specified hostname
  • no_proxy entries with/without wildcards

Fixes #716

m-bucher added 2 commits Jun 4, 2020
Fixes #716
@geemus
geemus approved these changes Jun 9, 2020
Copy link
Contributor

geemus left a comment

Looks good to me, thanks!

@geemus geemus merged commit 48e12ac into excon:master Jun 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@m-bucher m-bucher deleted the ATIX-AG:improve_no_proxy_handling branch Jun 10, 2020
@geemus
Copy link
Contributor

geemus commented Jun 12, 2020

Fix now released as part of 0.74.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.