Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ssl_verify_hostname parameter to use OpenSSL::SSL::SSLContext#verify_hostname= #722

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Jul 17, 2020

Currerntly, Excon does not handle OpenSSL::SSL::SSLContext#verify_hostname= method on Excon::SSLSocket class and does not provide way to handle whether handling verify_hostname option in ruby openssl or not.
Is this planned feature?

Signed-off-by: Hiroshi Hatake cosmo0920.oucc@gmail.com

…#verify_hostname=

Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
@geemus
Copy link
Contributor

geemus commented Jul 22, 2020

Looks great, thanks!

@geemus geemus merged commit c838a28 into excon:master Jul 22, 2020
1 check passed
geemus
geemus approved these changes Jul 22, 2020
@cosmo0920 cosmo0920 deleted the support-verify-hostname-parameter-on-ssl_context branch Jul 22, 2020
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jul 22, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants