Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摎 DOCS: Update the example #229

Merged
merged 3 commits into from Feb 22, 2023

Conversation

redstoneleo
Copy link
Contributor

It is a very bad idea to .disable('image') in the example , most newbies just copy the example to test, by .disable('image') causes unnecessary problem for them. I suffered the problem. So let's make a more user-friendly example.

It is a very bad idea to `.disable('image')` in the example , most newbies just copy the example to test, by  `.disable('image')` causes unnecessary problem for them. I suffered the problem. So let's make a more user-friendly example.
@welcome
Copy link

welcome bot commented Jan 10, 2023

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 馃帀

@chrisjsewell chrisjsewell changed the title updated the example 馃摎 DOCS: updated the example Feb 22, 2023
@chrisjsewell chrisjsewell changed the title 馃摎 DOCS: updated the example 馃摎 DOCS: Update the example Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 96.08% // Head: 96.08% // No change to project coverage 馃憤

Coverage data is based on head (7eb956b) compared to base (4670f0c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          62       62           
  Lines        3221     3221           
=======================================
  Hits         3095     3095           
  Misses        126      126           
Flag Coverage 螖
pytests 96.08% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
馃摙 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell chrisjsewell merged commit 2c93e0b into executablebooks:master Feb 22, 2023
14 checks passed
@welcome
Copy link

welcome bot commented Feb 22, 2023

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

@chrisjsewell
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants