Skip to content

🐛 FIX: smartquotes punctuation char comparison #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2020
Merged

🐛 FIX: smartquotes punctuation char comparison #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad0f46
Fix punctuation char comparison in smartquotes.py
hukkinj1 Nov 4, 2020
8cc8de3
Merge branch 'master' into fix-smartquotes
chrisjsewell Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion markdown_it/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def isPunctChar(ch):
}


def isMdAsciiPunct(ch: str):
def isMdAsciiPunct(ch: int):
"""Markdown ASCII punctuation characters.

::
Expand Down
8 changes: 2 additions & 6 deletions markdown_it/rules_core/smartquotes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,8 @@ def process_inlines(tokens: List[Token], state: StateCore):
nextChar = charCodeAt(tokens[j].content, 0)
break

isLastPunctChar = isMdAsciiPunct(chr(lastChar)) or isPunctChar(
chr(lastChar)
)
isNextPunctChar = isMdAsciiPunct(chr(nextChar)) or isPunctChar(
chr(nextChar)
)
isLastPunctChar = isMdAsciiPunct(lastChar) or isPunctChar(chr(lastChar))
isNextPunctChar = isMdAsciiPunct(nextChar) or isPunctChar(chr(nextChar))

isLastWhiteSpace = isWhiteSpace(lastChar)
isNextWhiteSpace = isWhiteSpace(nextChar)
Expand Down