-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to launch from binder with nbgitpuller #282
Comments
[sorry for the noise] Alternatively, could you maybe point me to a way to change Thanks!!! |
@fmaussion could you just manually over-ride via custom Sphinx configuration, like here: https://jupyterbook.org/advanced/sphinx.html#manual-sphinx-configuration ? |
Thanks @choldgraf ! I'm afraid I don't understand sphinx well enough to see what you mean... To me it looks like I need to execute some python code after that sphinx-book-theme has done its stuff? By looking at sphinx-book-theme, the path I'm exploring right now is to have a very trivial sphinx extension ("update-hub-url"), which would have it's own def setup(app: Sphinx):
# Configuration for Juypter Book
app.connect("html-page-context", update_binder_urls) with If my extension code is running after sphinx-book-theme itself and sill has access to the info it needs from it ( |
Yes, this is pretty important for having a jupyter version of lecture notes in a self contained and cloneable repo, with the environment or manifest files? Not sure how nbgitpuller could work otherwise? Or are you saying thereis a workaround? In my mind, binder is just one of multiple nbgitpuller based ways to trigger things from the same repo and it would just another in a list e.g jupyter-book/jupyter-book#1253 |
@mmcky thoughts? |
@jlperla currently for But I think I can see the use case here for having a |
Big 👍 to this idea! I am updating my book for Earth and Environmental Data Science and I'm really wishing for this feature. I would like to be able to launch the book notebooks into a binder with the images coming from https://github.com/pangeo-gallery/default-binder. In the Pangeo community, it is becoming common practice to separate the environment repo from the content repo. Unfortunately jupyter book + sphinx book theme don't support this right now. |
This is a follow-up to a post I opened on meta
For reasons discussed at length here, I'd like my JupyterBook notebooks to be launched via gitpuller in another binder-ready repository.
This is quite niche I suppose, but if you'd agree to have this as a feature I'd be happy to submit a PR for this functionality. The exact API is a bit fuzzy in my mind though.
I'd start by adding an option here:
sphinx-book-theme/sphinx_book_theme/launch.py
Lines 97 to 109 in 72f417b
by adding something that could look like:
It starts to become quite dirty at the moment where you'd like fine tuned control on the branch to use on the binder repo, etc.
Just let me know what you think. I have a patched version that does what I want (book) and I guess that I could also get what I want by writing an extension to
sphinx-book-theme
.The text was updated successfully, but these errors were encountered: