馃悰 FIX: Fixing sidebar animation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gonna merge this one in since it's a bugfix, but @DrDrij please let me know if I've missed something |
pradyunsg
reviewed
May 11, 2021
| @@ -12,6 +12,19 @@ | |||
| transition: margin-left .2s ease 0s, opacity .2s ease 0s, visibility .2s ease 0s; | |||
| z-index: 2000 !important; | |||
|
|
|||
| // Over-ride bootstrap collapsing styles for a smooth transition | |||
| &.collapse { | |||
| visibility: hidden; | |||
There was a problem hiding this comment.
Just the visibility one?
There was a problem hiding this comment.
Yea, the visibility rules seem unnecessary to me, given that this is gonna be off-canvas anyway.
I might be wrong tho.
There was a problem hiding this comment.
ahh I think you're right, but it does have a nice effect as a "fade out" in the animation :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the sidebar animation per @DrDrij's suggestions in #324 . Also adds a temporary favicon because I realize that ours was getting super scrunched.
@DrDrij does this look correct to you? Am I missing anything?
closes #330