Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the admonition icon flip vertically instead of rotate #38

Closed
choldgraf opened this issue Mar 23, 2022 · 0 comments · Fixed by #39
Closed

Make the admonition icon flip vertically instead of rotate #38

choldgraf opened this issue Mar 23, 2022 · 0 comments · Fixed by #39
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Member

Describe the problem/need and solution

In this Twitter thread we got some feedback that the semantics of the arrow for the admonition toggle button were a bit confusing. The general consensus from folks seemed to be:

  • If the arrow is to the right of the element, it should point down when closed, and point up when open.
  • If the arrow is to the left of the element, it should point right when closed, and point down when open.

We could apply that to our toggle behavior with admonitions. Instead of making it rotate horizontally, we could make it flip vertically.

Guide for implementation

This would be pretty easy to do with the following CSS rules:

    transform: scaleY(-1);
    transition: transform .2s ease-out;

This would make an animation like this when the label box is checked:

chrome_XdBz6Zam6q

Tasks and updates

No response

@choldgraf choldgraf added the enhancement New feature or request label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant