Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Instrumentation : memory optimization #46

Open
doriancransac opened this issue Apr 16, 2016 · 2 comments
Open

[Client] Instrumentation : memory optimization #46

doriancransac opened this issue Apr 16, 2016 · 2 comments
Assignees

Comments

@doriancransac
Copy link
Contributor

Instrumenting a method called often leads to very high memory consumption. In my mind, memory usage should be or nearly be independant from the frequency at which methods are called (see implementation of "InstrumentationSample" but probably more importantly (more surprising) the cardinality of StackTraceElement :

image

In my case, I was sampling at the default 1sec interval and just instrumented a java method which was called 3 million times. It pretty much killed the JVM (-> filled up approximately 2 GB Memory). Is there a way to optimize this?

image

@doriancransac
Copy link
Contributor Author

Exception in thread "Thread-4" java.lang.NegativeArraySizeException
at io.djigger.monitoring.java.sampling.ThreadDumpHelper.toStackTraceElement(ThreadDumpHelper.java:47)
at io.djigger.agent.Collector.report(Collector.java:54)
at java.util.TreeMap.remove(TreeMap.java:609)
at io.djigger.collector.test.BasicJMXJVM.iSleepUsingCPU(BasicJMXJVM.java:123)
at io.djigger.collector.test.BasicJMXJVM.iWaste50pcOfTheTimeButIUseCPU(BasicJMXJVM.java:103)
at io.djigger.collector.test.BasicJMXJVM.main(BasicJMXJVM.java:59)
java.lang.OutOfMemoryError: GC overhead limit exceeded
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1537)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.writeArray(ObjectOutputStream.java:1378)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1174)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
at java.util.ArrayList.writeObject(ArrayList.java:762)
at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
Exception in thread "main" java.lang.OutOfMemoryError: GC overhead limit exceeded
at io.djigger.monitoring.java.sampling.ThreadDumpHelper.toStackTraceElement(ThreadDumpHelper.java:50)
at io.djigger.agent.Collector.report(Collector.java:54)
at java.util.TreeMap.remove(TreeMap.java:609)
at io.djigger.collector.test.BasicJMXJVM.iSleepUsingCPU(BasicJMXJVM.java:127)
at io.djigger.collector.test.BasicJMXJVM.iWaste50pcOfTheTimeButIUseCPU(BasicJMXJVM.java:103)
at io.djigger.collector.test.BasicJMXJVM.main(BasicJMXJVM.java:59)

@doriancransac
Copy link
Contributor Author

High memory overhead on the target JVM's side as well. (see previous comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants