use lts-slim instead of lts-alpine #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larshp Let me know when you want me to review! |
|
ready for review |
ErikSchierboom
approved these changes
Jan 10, 2022
| RUN apk add --no-cache git | ||
| RUN apt-get -y update | ||
| RUN apt-get -y upgrade | ||
| RUN apt-get -y install git |
There was a problem hiding this comment.
Completely optional: I think there's also a command you can run to cleanup things a bit to reduce the size of the image slightly: https://github.com/exercism/prolog-test-runner/blob/main/Dockerfile#L8
There was a problem hiding this comment.
added, f3b6c1f
there is something wrong with "npm link" in alpine or this setup somewhere, its beyond me, just needed an easy fix 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is something strange happening in lts-alpine when running "npm link", which makes it take 10seconds
this changes to use the lts-slim docker image instead, which dramatically reduces runtime(9+ seconds reduction)