Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect bats changes (https://github.com/exercism/bash/pull/541) #27

Merged
merged 2 commits into from Sep 17, 2021
Merged

Reflect bats changes (https://github.com/exercism/bash/pull/541) #27

merged 2 commits into from Sep 17, 2021

Conversation

braoult
Copy link
Contributor

@braoult braoult commented Sep 16, 2021

No description provided.

@braoult braoult requested a review from a team as a code owner September 16, 2021 13:15
@iHiD
Copy link
Member

iHiD commented Sep 16, 2021

This must continue to work on people's older solutions and newer solutions, so we'll need support for both in here.

@braoult
Copy link
Contributor Author

braoult commented Sep 16, 2021 •
edited

This must continue to work on people's older solutions and newer solutions, so we'll need support for both in here.

It does support both current and new file names. This is done line 78 of run.sh:

# test scripts may be (old) xxxx_test.sh
[[ -f "$test_file" ]] || test_file=${slug//-/_}_test.sh

In fact, if you look at tests changes, you will notice I renamed 4/7 bats files to new names, and kept 3 with old name, exactly for that.

@braoult braoult mentioned this pull request Sep 16, 2021
Merged
glennj
glennj approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

IsaacG
IsaacG reviewed Sep 16, 2021
View reviewed changes
bin/run.sh Outdated Show resolved Hide resolved
@iHiD iHiD merged commit 0df031f into exercism:main Sep 17, 2021
@braoult braoult deleted the rename-bats-files branch September 17, 2021 09:45
@braoult braoult mentioned this pull request Sep 17, 2021
Closed
glennj pushed a commit to glennj/exercism-bash-test-runner that referenced this pull request Sep 23, 2021
@braoult @glennj
Reflect bats changes (exercism/bash#541) (exercism#27)
bd3467a 
* Reflect bats changes (exercism/bash#541)

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacG IsaacG IsaacG left review comments

@glennj glennj glennj approved these changes

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@braoult @iHiD @glennj @ErikSchierboom @IsaacG