From 946a01e6e585974a6692030841f80256e51fff8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20B=20Nagy?= <20251272+BNAndras@users.noreply.github.com> Date: Fri, 31 Oct 2025 19:58:58 -0700 Subject: [PATCH 1/2] Sync docs --- exercises/practice/triangle/.docs/instructions.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exercises/practice/triangle/.docs/instructions.md b/exercises/practice/triangle/.docs/instructions.md index 755cb8d1..e9b053dc 100644 --- a/exercises/practice/triangle/.docs/instructions.md +++ b/exercises/practice/triangle/.docs/instructions.md @@ -14,7 +14,8 @@ A _scalene_ triangle has all sides of different lengths. For a shape to be a triangle at all, all sides have to be of length > 0, and the sum of the lengths of any two sides must be greater than or equal to the length of the third side. ~~~~exercism/note -We opted to not include tests for degenerate triangles (triangles that violate these rules) to keep things simpler. +_Degenerate triangles_ are triangles where the sum of the length of two sides is **equal** to the length of the third side, e.g. `1, 1, 2`. +We opted to not include tests for degenerate triangles in this exercise. You may handle those situations if you wish to do so, or safely ignore them. ~~~~ From cd02425c4c5f2d67c0f9c0eee4eaa60b5d21846d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20B=20Nagy?= <20251272+BNAndras@users.noreply.github.com> Date: Fri, 31 Oct 2025 20:02:49 -0700 Subject: [PATCH 2/2] Sync tests --- .../practice/isbn-verifier/.meta/tests.toml | 19 ++++++++++++++++--- .../isbn-verifier/isbn-verifier-test.lisp | 8 ++++++++ 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/exercises/practice/isbn-verifier/.meta/tests.toml b/exercises/practice/isbn-verifier/.meta/tests.toml index 2ea0445b..17e18d47 100644 --- a/exercises/practice/isbn-verifier/.meta/tests.toml +++ b/exercises/practice/isbn-verifier/.meta/tests.toml @@ -1,6 +1,13 @@ -# This is an auto-generated file. Regular comments will be removed when this -# file is regenerated. Regenerating will not touch any manually added keys, -# so comments can be added in a "comment" key. +# This is an auto-generated file. +# +# Regenerating this file via `configlet sync` will: +# - Recreate every `description` key/value pair +# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications +# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) +# - Preserve any other key/value pair +# +# As user-added comments (using the # character) will be removed when this file +# is regenerated, comments can be added via a `comment` key. [0caa3eac-d2e3-4c29-8df8-b188bc8c9292] description = "valid isbn" @@ -23,6 +30,12 @@ description = "invalid character in isbn is not treated as zero" [28025280-2c39-4092-9719-f3234b89c627] description = "X is only valid as a check digit" +[8005b57f-f194-44ee-88d2-a77ac4142591] +description = "only one check digit is allowed" + +[fdb14c99-4cf8-43c5-b06d-eb1638eff343] +description = "X is not substituted by the value 10" + [f6294e61-7e79-46b3-977b-f48789a4945b] description = "valid isbn without separating dashes" diff --git a/exercises/practice/isbn-verifier/isbn-verifier-test.lisp b/exercises/practice/isbn-verifier/isbn-verifier-test.lisp index bb386a8e..b4d4aa27 100644 --- a/exercises/practice/isbn-verifier/isbn-verifier-test.lisp +++ b/exercises/practice/isbn-verifier/isbn-verifier-test.lisp @@ -43,6 +43,14 @@ (let ((isbn "3-598-2X507-9")) (is-false (isbn-verifier:validp isbn)))) +(test only-one-check-digit-is-allowed + (let ((isbn "3-598-21508-96")) + (is-false (isbn-verifier:validp isbn)))) + +(test x-is-not-substituted-by-the-value-ten + (let ((isbn "3-598-2X507-5")) + (is-false (isbn-verifier:validp isbn)))) + (test valid-isbn-without-separating-dashes (let ((isbn "3598215088")) (is-true (isbn-verifier:validp isbn))))