New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exercise template for luhn. #302

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jkrukoff

jkrukoff commented Dec 3, 2018

This updates the exercise source template to match the test version in
the current test suite. In addition, it removes a function that is not
used in the current test suite.

My guess is that the template was not updated the last time the test suite was?

jkrukoff added some commits Dec 3, 2018

Update exercise template for luhn.
This updates the exercise source template to match the test version in
the current test suite. In addition, it removes a function that is not
used in the current test suite.
Remove export as well.
Also remove the export for the removed function.
@juhlig

This comment has been minimized.

Contributor

juhlig commented Dec 3, 2018

Thanks. As far as I can see, there never was a test for create/1 at all. This was implemented before my time, so I don't know how it ended up in there.

But while you're at it, can you please have a look at #278, which actually obsoletes version tracking? I had been starting work on this once, but got distracted =^^=

In a nutshell, remove the version test from the test suite and the module stub, and the corresponding paragraph from README.md (that last thing, a run of bin/configlet generate . -o luhn can do that for you automatically).

@juhlig

This comment has been minimized.

Contributor

juhlig commented Dec 5, 2018

Your PR prompted me to take the improved test generator for a spin with luhn. Worked out quite well, I must say. Therefore, I have a PR that supersedes this one: #320.

Thus, I will close this PR, and thank you for your work.

@juhlig juhlig closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment