New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language icon to team stream #3072
Conversation
Great ❤️ Can you add before/after screenshots to this PR please. |
Will this also cause the icon to appear on regular language streams? (It's probably fine if it does, but it would be nice to have the consideration documented and maybe add a screenshot of that case too.) |
Also on the regular language tracks that aren't part of a team stream, for example: http://exercism.io/tracks/ruby/exercises |
@@ -17,6 +17,7 @@ | |||
<h4> | |||
<%= exercise.problem.name %> | |||
<span class="profile"> <%= exercise.username %> </span> | |||
<span class="track-icon"><%= track_icon(exercise.problem.track_id, 20) %></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to get some alt-text for this icon too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radar that will require changing the track_icon view helper and probably belongs in a different PR, will you create a new issue for it please?
I merged it manually in 0de777d |
Thank you so much @bradhvr! |
@kytrinyx, I think my CSS change may inadvertently have gotten dropped in the merge. It looks like the compiled
Here's what I see in my dev environment: What would be the best way to fix this? |
I'll recompile locally and see if it gets added. |
I think that worked. Thanks for catching that. |
Great, thanks! |
I added the language icon to the top right of the team stream solutions, per issue #3020.