Document that port 8000 must be used for lineman reloading #3431

Merged
merged 1 commit into from Mar 25, 2017

Conversation

Projects
None yet
3 participants
@nilbus
Member

nilbus commented Mar 25, 2017

Using port 4567, I couldn't figure out why my JS wouldn't reload with lineman building things for me. Hopefully this will help others later who hit the same problem.

@kotp

This comment has been minimized.

Show comment
Hide comment
@kotp

kotp Mar 25, 2017

Member

Can someone verify this is indeed a requirement for this specific port number? A reference perhaps? It feels to me that it should be configurable to match whatever rackup is set up to.

Member

kotp commented Mar 25, 2017

Can someone verify this is indeed a requirement for this specific port number? A reference perhaps? It feels to me that it should be configurable to match whatever rackup is set up to.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Mar 25, 2017

Member

It seems to be convention, documented all over docs/setting-up-local-development.md, and hard-coded in the lineman config, frontend/config/application.coffee.

Member

nilbus commented Mar 25, 2017

It seems to be convention, documented all over docs/setting-up-local-development.md, and hard-coded in the lineman config, frontend/config/application.coffee.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Mar 25, 2017

Member

docker-compose.yml also uses 4567, consistent with everything else.

That's not to say it couldn't be changed, but the default rackup port and default puma port aren't the same.

Member

nilbus commented Mar 25, 2017

docker-compose.yml also uses 4567, consistent with everything else.

That's not to say it couldn't be changed, but the default rackup port and default puma port aren't the same.

@kytrinyx kytrinyx merged commit b2212cb into exercism:master Mar 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.395%
Details
@kytrinyx

This comment has been minimized.

Show comment
Hide comment
@kytrinyx

kytrinyx Mar 25, 2017

Member

Thanks, @nilbus.

Member

kytrinyx commented Mar 25, 2017

Thanks, @nilbus.

@nilbus nilbus deleted the nilbus:document-reloading-port branch Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment