Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to "mine" at top of track activity streams #2860

Closed
kytrinyx opened this issue May 2, 2016 · 7 comments

Comments

@kytrinyx
Copy link
Member

commented May 2, 2016

We have two activity streams:

  1. One for teams which can filter by language, by language/problem, by user, and by user/problem.
  2. One for tracks, which filters only by language and language/problem.

On the track activity stream, it would be useful to have a quick way to get to everything by the user who is currently logged in. This would not include archived stuff, since that is the default in streams.

If nobody is logged in, there would be no such menu item.

Here's the current sidebar for track streams:

activity-stream

The track stream code starts in lib/exercism/track_stream.rb. In particular, look at lib/exercism/track_stream.rb:35 at the method called menus. We loop over these menus in the view template in order to produce the sidebar.

We don't currently have a UserFilter for the track stream, but we do have one for the team stream which we could look for. Look at lib/exercism/track_stream_filters.rb and lib/exercism/team_stream_filters.rb.

See discussion in #2803

@jmromer

This comment has been minimized.

Copy link

commented May 6, 2016

@kytrinyx As a first pass:

screen shot 2016-05-06 at 10 13 40 am

I'm not entirely sure what to label the filter -- I felt torn between "My solutions" and "My implementations". I'm probably overthinking it, but I wonder if you have any strong feelings either way...

@kytrinyx

This comment has been minimized.

Copy link
Member Author

commented May 8, 2016

I don't have any strong feelings either way, but here's how I've been using words lately:

  • solution: refers to code written by a user to solve an exercise. A solution might have many iterations.
  • problem/exercise - more or less used interchangeably
  • implementation - a language-specific implementation of a problem

Based on that I'd slightly lean towards "solutions" as you have here.

@ramyaravindranath

This comment has been minimized.

Copy link

commented Sep 15, 2016

@kytrinyx : Looking into this.

@ramyaravindranath

This comment has been minimized.

Copy link

commented Sep 15, 2016

@jkrmr Are you still working on the issue ?

@jmromer

This comment has been minimized.

Copy link

commented Sep 15, 2016

@ramyaravindranath thanks for the ping! I'd actually lost track of this issue. I haven't started work on it yet, and realistically probably won't have time to in the near future, so if you'd like to run with it, go for it.

@ramyaravindranath

This comment has been minimized.

Copy link

commented Sep 19, 2016

Currently on tracks, filters for language and language/problem exists and do not have option of filtering user's solutions/exercises.

PR : #3115 adds a filter on tracks where user can filter out only his/her solutions for a particular language. The filtered results doesn't include archived exercises.

Below is the screen shot.
screenshot from 2016-09-20 10-57-07

@Insti

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2016

Resolved by #3115

@Insti Insti closed this Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.