Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Issue - Correct margins below code snippets #3046

Closed
ghost opened this issue Aug 11, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@ghost
Copy link

commented Aug 11, 2016

As noted in #2535, we have a visual problem with margins below code snippets - in that there doesn't appear to be any. I'm not sure how widespread this issue is, but I've noticed it in the following:
http://exercism.io/cli
http://exercism.io/help (screenshot below)
cssmarginproblem

I've tried to find the appropriate css, have come up with <div class = “highlight shell”>, but got stuck re: how to find and change the source file, and which content is dependent on that source.

@ghost ghost changed the title Correct margins below code snippets Design Issue - Correct margins below code snippets Aug 11, 2016

@Insti

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2016

Try: exercism.io/public/sass/base/components/pygments.scss

Found by grepping the sass files for \.highlight and looking at a few matching files to see which one had the other css properties.

@troubalex

This comment has been minimized.

Copy link

commented Aug 12, 2016

Try: exercism.io/public/sass/base/components/pygments.scss

Isn't that the standard Pygments styles file? If so, adding a margin here would overwrite it if Pygments ever is updated.

If that is the case, adding a margin to .highlight could be done in exercism.scss

@Insti

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2016

@troubalex I know more about grep than I do about scss :) so I'm happy to see your recommendations.

@troubalex

This comment has been minimized.

Copy link

commented Aug 12, 2016

I double checked, and the change should probably go into exercism.io/public/sass/application.scss

@bernardoamc

This comment has been minimized.

Copy link
Member

commented Aug 16, 2016

We can tag this with good first patch. =]

@bradhvr

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2016

Hello, I've created pull request #3062 for this issue.

@nickborromeo

This comment has been minimized.

Copy link
Member

commented Aug 20, 2016

looks like the fix for this was merged 😄 we should close this issue out.

@Insti Insti closed this Aug 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.