Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When new exercises are added to Exercism Tracks, how do they get auto-unlocked for students who should have access? #3867

Closed
rpottsoh opened this issue Jul 16, 2018 · 16 comments

Comments

@rpottsoh
Copy link
Member

@rpottsoh rpottsoh commented Jul 16, 2018

@iHiD, @kytrinyx I have just added pangram to the Delphi track. It is not a core exercise and is unlocked by hello-world. I see the exercise listed on the Delphi language page, but it is locked. My account on the site has all the other Delphi exercises unlocked and completed. I do not know how to unlock pangram.

@NobbZ
Copy link
Member

@NobbZ NobbZ commented Jul 16, 2018

Has your hello world solution been approved by a mentor and completed by you? Or is it just in legacy mode?

@rpottsoh
Copy link
Member Author

@rpottsoh rpottsoh commented Jul 16, 2018

On the Delphi track page hello-world is simply listed as completed. If I click into hello-world I can View published solution and in the Mentor Discussion section there is a Next Steps blurb with a button to Start another exercise which just takes me back to the Delphi track page. In config.json I have "auto-approve" set to true for hello-world.

As a student in my own track I cannot mentor myself out of this. @amoradell needs to complete the steps outlined in #start-here. They are slated to also mentor the Delphi track.

I am operating in normal mode on the site.

@iHiD iHiD changed the title Delphi Track: unable to unlock recently added exercise When new exercises are added to Exercism Tracks, how do they get auto-unlocked for students who should have access? Jul 17, 2018
@rpottsoh
Copy link
Member Author

@rpottsoh rpottsoh commented Jul 19, 2018

@iHiD I would like to report that the previously locked exercise is now no longer locked. 🍾 Thanks. Also, listing the available exercises beneath each of the core exercises is a nice touch. 👍

For me this issue is closed. Feel free to close.

@rpottsoh
Copy link
Member Author

@rpottsoh rpottsoh commented Jul 27, 2018

Please see related comments in dupe #4080

@amoradell
Copy link

@amoradell amoradell commented Sep 23, 2018

Unfortunately, workaround doesn't work for me (delphi track, acronym exercise)

D:\exercism download -t delphi -e acronym
Error: You have not unlocked this exercise

@kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Nov 13, 2018

I think this has been solved. I'm going to go ahead and close this. If it's not solved for you, would you please comment here and I'll re-open it so we can investigate?

@kytrinyx kytrinyx closed this Nov 13, 2018
@rpottsoh
Copy link
Member Author

@rpottsoh rpottsoh commented Nov 13, 2018

I have checked again for the symptom that raised this issue and am no longer coming across it. 👍 I have no idea when it was fixed...

@iHiD
Copy link
Member

@iHiD iHiD commented Nov 14, 2018

I run this manually each time.

@rpottsoh
Copy link
Member Author

@rpottsoh rpottsoh commented Nov 14, 2018

ewww. So you are manually keeping tabs on when exercises are being added and then (re)applying a fix? Thanks for doing this. Hopefully at some point you won't have to personally step in. Can this be automated? Or are you working on a permanent solution?

@iHiD
Copy link
Member

@iHiD iHiD commented Nov 14, 2018

@ErikSchierboom messages me every time anyone adds an exercise, then I run a script :)

The script takes about 8hrs to run. It's hard to speed up :)

@ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Nov 14, 2018

And there is of course the caveat that I only notify Jeremy when I see a change (and that only happens for the tracks I've completed).

@rpottsoh
Copy link
Member Author

@rpottsoh rpottsoh commented Nov 14, 2018

ugh.... I have been adding exercises to the Delphi track at a pretty healthy clip, thanks to @filiptoskovic. I am not sure anymore I if all the new exercises are properly unlocked. I no longer hold the status of having completed all the core exercises. 😄

@filiptoskovic I believe you have completed all the core exercises in Delphi. Are you able to tell if any of the recent exercises that you have added, that you should be able to access, are currently locked?

Likely all but maybe the most recent additions will be properly unlocked for you as @iHiD runs "the fix" script with enough frequency.

@ErikSchierboom and @iHiD thanks for keeping tabs on the additions.

@filiptoskovic
Copy link

@filiptoskovic filiptoskovic commented Nov 15, 2018

@rpottsoh I have completed 14/15 exercises. All exercises are unlocked except last one (Luhn).

@iHiD
Copy link
Member

@iHiD iHiD commented Nov 15, 2018

I've run the script probably 3 times per week, and it's global. If anyone wants to take a gander,
I'd appreciate your thoughts. The script is here. It needs:

  • Making it faster
    and/or
  • Making it more SQL based (without locking things)

The key is probably writing something that just checks what's changed, and then working out who might be affected, rather than acting upon everything. That should make it all faster.

@arthurhess
Copy link

@arthurhess arthurhess commented Jan 13, 2021

Hi, is this still an issue? I was going to suggest creating an ActiveJob worker for the FixUnlockingInUserTrack service and setting it up to run daily with sidekiq-scheduler or something of the sort.

Does it make sense?

@iHiD
Copy link
Member

@iHiD iHiD commented Jan 13, 2021

It won't be an issue in v3. Thanks for the suggestion though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants