Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Introduce "what next instructions" to submission API response #3414
This is paired with exercism/cli#377 but does not need not need a synchronized release. This change forward/backward compatible, tested in all combinations of new & old exercism.io and new & old cli.
In clients that support it, the "what next instructions" will be displayed after a new iteration is submitted.
This allows us to modify the message anytime, without having to wait for users to update their cli version.
Part of the experiment outlined in exercism/discussions#123.
In clients that support it, the "what next instructions" will be displayed after a new iteration is submitted. This allows us to modify the message anytime, without having to wait for users to update their cli version.
Two things I'd be interested in feedback on:
If this all looks good to you though, we can .
Since the application refuses to run on anything other than the version specified in .ruby-version and the Gemfile, there's no reason to maintain support for earler versions. Despite what the [Rubocop docs] say, rubocop is targeting ruby 2.0 when TargetRubyVersion is unspecified. [Rubocop docs]: https://github.com/bbatsov/rubocop/blob/master/manual/configuration.md#setting-the-target-ruby-version
Nah, I think that's fine. I think it makes sense to keep it close to where it's used. If we start having a lot of these sorts of things, we might have some sort of config file somewhere, but I think adding indirection would be overkill here.
Yes, it looks good. In the earlier PR that hard-coded it in the CLI you had two versions based on the experiment. Will you be adding the old copy to flip between them?
One last thought: should we record the version of the CLI that someone submits an iteration with? That would let us determine who saw the feature or not.
Both that, and it could tell us whether or not to show a banner asking the user to upgrade.
I'll open a PR for cli to include the version in at least submission API calls.