Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow project migration id naming convention #3417

Merged
merged 1 commit into from Mar 21, 2017

Conversation

@nilbus
Copy link

@nilbus nilbus commented Mar 21, 2017

This migration was created following the rails convention of including
seconds digits in the id, rather than the project convention.

Since this migration may already have run in some environments, this
patch cleans up after the rename.

  • The migration is renamed
  • The old migration id is discarded in schema_migrations
  • If the migration work was already done, return and do nothing.
@nilbus nilbus force-pushed the nilbus:follow-migration-convention branch from 3a807b3 to 528dbcb Mar 21, 2017
This migration was created following the rails convention of including
seconds digits in the id, rather than the project convention.

Since this migration may already have run in some environments, this
patch cleans up after the rename.
@nilbus nilbus force-pushed the nilbus:follow-migration-convention branch from 528dbcb to 67d05a4 Mar 21, 2017
@kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Mar 21, 2017

Thanks @nilbus. For future reference there's a rake task that will create the migration for you using the expected naming convention:

Usage: rake db:generate:migration name=the_name_of_your_migration
@kytrinyx kytrinyx merged commit 99827e2 into exercism:master Mar 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.57%
Details
@nilbus nilbus deleted the nilbus:follow-migration-convention branch Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants