New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow flipper-suggested feature name convention #3424

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
2 participants
@nilbus
Member

nilbus commented Mar 23, 2017

Recommended naming conventions: lower case, snake case, underscores over dashes.
Good: foo_bar, foo.
Bad: FooBar, Foo Bar, foo bar, foo-bar.

—/flipper/features/new

Follow flipper-suggested feature name convention
> Recommended naming conventions: lower case, snake case, underscores
> over dashes. Good: foo_bar, foo. Bad: FooBar, Foo Bar, foo bar,
> foo-bar.
-- /flipper/features/new
@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Mar 23, 2017

Member

Both of our feature flags at /flipper/features now follow this convention.

Member

nilbus commented Mar 23, 2017

Both of our feature flags at /flipper/features now follow this convention.

@kytrinyx kytrinyx merged commit 57b2a2c into exercism:master Mar 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.628%
Details
@kytrinyx

This comment has been minimized.

Show comment
Hide comment
@kytrinyx

kytrinyx Mar 23, 2017

Member

That works for me. Thanks!

Member

kytrinyx commented Mar 23, 2017

That works for me. Thanks!

@nilbus nilbus deleted the nilbus:feature-name-convention branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment