New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random sentence starter placeholders for comments #3435

Merged
merged 3 commits into from Mar 26, 2017

Conversation

Projects
None yet
2 participants
@nilbus
Member

nilbus commented Mar 26, 2017

This is part of the experiment in exercism/discussions#123.

@kytrinyx Please note the commit message in 1880d11

This feature has a similar theme to Prompts. I think they could work alright together, but I'd be interested to get feedback on how that works in practice.

nilbus added some commits Mar 26, 2017

Alphabetize exercism.rb requires
This helps make it clear where to put new requires, and distributes new
requires in such a way that future conflicts are less likely.

All the tests pass still...

Any load-time dependency order requirements should theoretically blow up
immediately during the require. That wouldn't hold true if some class
were using metaprogramming to search for existing constants to create a
list of things matching a pattern or something, but are we doing that?

@kytrinyx, is there any reason you can think of that reordering here may
cause problems?
@kytrinyx

This comment has been minimized.

Show comment
Hide comment
@kytrinyx

kytrinyx Mar 26, 2017

Member

@kytrinyx, is there any reason you can think of that reordering here may cause problems?

If there were issues, they'd show up when running the tests, so I think we're fine.

Member

kytrinyx commented Mar 26, 2017

@kytrinyx, is there any reason you can think of that reordering here may cause problems?

If there were issues, they'd show up when running the tests, so I think we're fine.

@kytrinyx kytrinyx merged commit 654556f into exercism:master Mar 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 85.488%
Details

@nilbus nilbus deleted the nilbus:sentence-starters branch Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment