New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "Help make this better" text on track topic pages #3475

Merged
merged 11 commits into from May 17, 2017

Conversation

Projects
None yet
3 participants
@nholden
Contributor

nholden commented Apr 22, 2017

#3355 pointed out that the instructions for filing an issue or submitting a patch were not showing up on language track topic pages. This adds that text to the bottom of those pages.

Show outdated Hide outdated app/presenters/track.rb Outdated
Show outdated Hide outdated test/app/presenters/track_test.rb Outdated
# Enhances the track-specific documentation, adding
# defaults where missing and embellishments that encourage
# people to submit improvements.
class Track

This comment has been minimized.

@nholden

nholden Apr 22, 2017

Contributor

Now that we use the Trackler gem to grab track-specific content, we don't use this class. Instead, we have a Track presenter that essentially wraps the Trackler track.

@nholden

nholden Apr 22, 2017

Contributor

Now that we use the Trackler gem to grab track-specific content, we don't use this class. Instead, we have a Track presenter that essentially wraps the Trackler track.

Show outdated Hide outdated app/presenters/track.rb Outdated
Show outdated Hide outdated app/presenters/track.rb Outdated
@Insti

Insti approved these changes Apr 22, 2017

The changes that @nholden has made are all reasonable.
My nitpicks appear to all be with the pre-exisiting code.
That shouldn't be a blocker for merging.

Nick Holden added some commits Apr 22, 2017

Nick Holden
Include "Help make this better" text on track topic pages
Issue #3355 pointed out that the instructions for filing an issue or
submitting a patch were not showing up on language track topic pages.
This adds that text to the bottom of those pages.
Nick Holden
Remove unuses X::Docs::Track class
We're no longer using X::Docs::Track to display track-specific
documentation. Instead, we have a Track presenter that wraps data
returned by the Trackler gem.
Nick Holden
@nholden

This comment has been minimized.

Show comment
Hide comment
@nholden

nholden Apr 23, 2017

Contributor

@Insti Thanks for all your helpful comments! I went ahead and tried to address them here.

If you'd prefer, I'm also happy to let someone merge what you approved and open up another PR for refactoring. Let me know what you think!

Contributor

nholden commented Apr 23, 2017

@Insti Thanks for all your helpful comments! I went ahead and tried to address them here.

If you'd prefer, I'm also happy to let someone merge what you approved and open up another PR for refactoring. Let me know what you think!

fallback_topic_content(topic_name)
end
trackler_topics.each_with_object(OpenStruct.new) do |topic_key, result|
result[topic_key] = topic_content(topic_key)

This comment has been minimized.

@Insti

Insti Apr 23, 2017

Contributor

Excellent ⭐️

@Insti

Insti Apr 23, 2017

Contributor

Excellent ⭐️

@Insti

Insti approved these changes Apr 23, 2017

I really like everything you've done here.

I have a few more minor things that could be improved, feel free to tell me you don't want to do them.

Show outdated Hide outdated test/app/presenters/track_test.rb Outdated
Show outdated Hide outdated test/app/presenters/track_test.rb Outdated
Show outdated Hide outdated test/app/presenters/track_test.rb Outdated
Nick Holden
@nholden

This comment has been minimized.

Show comment
Hide comment
@nholden

nholden Apr 23, 2017

Contributor

Thanks, @Insti! I addressed your latest batch of feedback in 3afedaa, and I think the tests are looking a lot clearer.

Contributor

nholden commented Apr 23, 2017

Thanks, @Insti! I addressed your latest batch of feedback in 3afedaa, and I think the tests are looking a lot clearer.

@Insti

This comment has been minimized.

Show comment
Hide comment
@Insti

Insti Apr 23, 2017

Contributor

Great, thanks for all your work on this @nholden, I think this looks ready to go.
I'll let someone else give it a quick look over and hit the merge button in case I've missed anything.

Contributor

Insti commented Apr 23, 2017

Great, thanks for all your work on this @nholden, I think this looks ready to go.
I'll let someone else give it a quick look over and hit the merge button in case I've missed anything.

@Insti

Insti approved these changes Apr 23, 2017

@Insti

This comment has been minimized.

Show comment
Hide comment
@Insti

Insti Apr 23, 2017

Contributor

I also really liked the atomicity of your commits, it was a pleasure to review them. ❤️

Contributor

Insti commented Apr 23, 2017

I also really liked the atomicity of your commits, it was a pleasure to review them. ❤️

Show outdated Hide outdated app/presenters/track.rb Outdated
Nick Holden
Show outdated Hide outdated app/presenters/track.rb Outdated
Show outdated Hide outdated app/presenters/track.rb Outdated
Show outdated Hide outdated app/presenters/track.rb Outdated
Show outdated Hide outdated app/presenters/track.rb Outdated
@Insti

Insti approved these changes May 1, 2017

@kytrinyx

This comment has been minimized.

Show comment
Hide comment
@kytrinyx

kytrinyx May 17, 2017

Member

This is great, @nholden, thanks so much! ❤️

And thanks for all the thorough review, @Insti 🌻

Member

kytrinyx commented May 17, 2017

This is great, @nholden, thanks so much! ❤️

And thanks for all the thorough review, @Insti 🌻

@kytrinyx kytrinyx merged commit 6abcdc5 into exercism:master May 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 86.234%
Details

@nholden nholden deleted the nholden:better-text branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment