Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check $flipper feature flags for page requests #3553

Merged
merged 1 commit into from Jun 5, 2017

Conversation

@nilbus
Copy link

@nilbus nilbus commented Jun 5, 2017

Each page load generates a number of other asset requests, such as
/tracks/elixir/icon. Loading many of these at once, especially across
multiple concurrent users, has sometimes used up all the available
database connections in the DB pool.

The page_request? method is proven now and does not need to live behind
a feature flag.

Each page load generates a number of other asset requests, such as
/tracks/elixir/icon. Loading many of these at once, especially across
multiple concurrent users, has sometimes used up all the available
database connections in the DB pool.

The #page_request? method is proven now and does not need to live behind
a feature flag.
@kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Jun 5, 2017

Excellent, thank you!

@kytrinyx kytrinyx merged commit 0c37457 into exercism:master Jun 5, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 86.424%
Details
@nilbus nilbus deleted the nilbus:reduce-db-lookups branch Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants