New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert partial client version tracking #3564

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@nilbus
Member

nilbus commented Jun 23, 2017

Removing in favor of tracking this in individual clients (i.e. cli, gui).

Discussion: #3416 (comment)

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Jun 23, 2017

Member

Last step after merge:

  • Remove advertise_cli_update feature flag in the flipper UI.
Member

nilbus commented Jun 23, 2017

Last step after merge:

  • Remove advertise_cli_update feature flag in the flipper UI.

@nilbus nilbus closed this Jun 24, 2017

@nilbus nilbus reopened this Jun 29, 2017

@nilbus nilbus closed this Jun 29, 2017

nilbus added some commits Jun 23, 2017

Revert "Merge pull request #3422 from nilbus/please-update-cli-banner"
This reverts commit 55c705c, reversing
changes made to 57b2a2c.

Conflicts:

- app/routes/profile.rb [removed relevant lines]
- db/migrate/201703212321_add_client_version_notification_dismissed_at_to_users.rb [kept]
- lib/exercism/client_version.rb [removed]
- test/exercism/client_version_test.rb [removed]

The migration was kept and will be reversed in a subsequent commit.

Closes #3416

@nilbus nilbus reopened this Jun 29, 2017

@nilbus nilbus closed this Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment