Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default port, making .env optional #3591

Merged
merged 3 commits into from Jul 21, 2017

Conversation

@nilbus
Copy link

@nilbus nilbus commented Jul 20, 2017

Convention over configuration.

With this first step no longer needed, move OAuth configuration lower in the README, relative to its importance.

Changing the port is already documented. Removed the redundant reference.

Based on #3590 to avoid conflicts.

nilbus added 3 commits Jul 19, 2017
This enables the use of defaults with variable interpolation.

Followed procedure documented at
https://docs.docker.com/compose/compose-file/compose-versioning/#version-1-to-2x
With this first step no longer needed, move OAuth configuration lower in
the README, relative to its importance.

Changing the port is already documented. Removed the redundant
reference.
Despite the default being provided, if docker-compose.yml (by extension,
docker/common.yml) specifies an `env_file`, the file is required to
exist.

Related issue: docker/compose#3560
Related PR: docker/compose#3955

For now, we must continue to create this file.
@kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Jul 21, 2017

Good improvement, thanks!

@kytrinyx kytrinyx merged commit edcb31d into exercism:master Jul 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.524%
Details
@nilbus nilbus deleted the nilbus:docker-default-port branch Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants