New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a named Docker volume to better persist data #3592

Merged
merged 2 commits into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@nilbus
Member

nilbus commented Jul 20, 2017

Goal: Keep the database data around beyond the life of the DB container, and automatically attach it to new DB containers.

Without this, docker-compose down or otherwise removing the postgres container leaves orphan volumes that will not be reattached automatically.

Based on #3590 to avoid conflicts.

nilbus added some commits Jul 19, 2017

Upgrade docker-compose format to version 2.1
This enables the use of defaults with variable interpolation.

Followed procedure documented at
https://docs.docker.com/compose/compose-file/compose-versioning/#version-1-to-2x
Use a named Docker volume to better persist data
Otherwise, `docker-compose down' or otherwise removing the postgres
container leaves orphan volumes that will not be reattached
automatically.
@kytrinyx

This comment has been minimized.

Show comment
Hide comment
@kytrinyx

kytrinyx Jul 21, 2017

Member

Sweet, thank you!

Member

kytrinyx commented Jul 21, 2017

Sweet, thank you!

@kytrinyx kytrinyx merged commit 67304db into exercism:master Jul 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.524%
Details

@nilbus nilbus deleted the nilbus:docker-compose-volume branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment