New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bundle install in Docker build #3596

Merged
merged 2 commits into from Jul 25, 2017

Conversation

Projects
None yet
2 participants
@nilbus
Member

nilbus commented Jul 25, 2017

A couple improvements on the base Docker image build:

  • Install the version of bundler specified in Gemfile.lock
  • Take advantage of bundler's parallelism

nilbus added some commits Jul 25, 2017

Take advantage of bundler's parallelism
20 jobs is somewhat arbitrary.

Parallelism need not be limited to the number of logical cores. Because
installing gems is such an IO-intensive task, generally not CPU-bound,
we can typically see big speed wins by starting many at once.

@kytrinyx kytrinyx merged commit 6fac0ba into exercism:master Jul 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.622%
Details
@kytrinyx

This comment has been minimized.

Show comment
Hide comment
@kytrinyx

kytrinyx Jul 25, 2017

Member

Sweet, thanks!

Member

kytrinyx commented Jul 25, 2017

Sweet, thanks!

@nilbus nilbus deleted the nilbus:docker-bundler branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment