Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run configlet fmt to normalize configs #152

Merged
merged 2 commits into from Jan 23, 2023
Merged

Run configlet fmt to normalize configs #152

merged 2 commits into from Jan 23, 2023

Conversation

kytrinyx
Copy link
Member

This normalizes exercise configs, which should help
reduce noise in other PRs later.

This normalizes exercise configs, which should help
reduce noise in other PRs later.
This reformats the top-level config file in order to
reduce noise in later PRs that touch this file.
@kytrinyx
Copy link
Member Author

@jiegillet I noticed that #151 was changing some exercise configs that were unrelated to the exercise being added.

Unfortunately configlet fmt doesn't format the top-level config, so I grabbed the reformatted file from your isogram PR (#151), and removed the bit about isogram.

Copy link
Sponsor Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Is a particular tool used for this?

@jiegillet
Copy link
Contributor

For the exercise config the tool is bin/configlet fmt --update --yes.

For the top config, the generator script I use rewrites the config via jq, which also formats the file. Actually there is one annoying side effect/bug, the "average_run_time": 3.0 always gets transformed to to "average_run_time": 3 but the Exercism tool using this value requires an float. Haven't found a nice fix for that yet.

@jiegillet jiegillet merged commit 3d4e67d into main Jan 23, 2023
@jiegillet jiegillet deleted the configlet-fmt branch January 23, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants