Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diamond: extract common setup #359

Closed
jtigger opened this issue Mar 7, 2017 · 1 comment
Closed

diamond: extract common setup #359

jtigger opened this issue Mar 7, 2017 · 1 comment
Labels
code good first issue Good for newcomers

Comments

@jtigger
Copy link
Contributor

jtigger commented Mar 7, 2017

In the diamond exercise, every test method duplicates the construction of the instance of DiamondPrinter.

Please extract the construction into a setUp() method and use the instance data member instead.
@jtigger jtigger added code good first issue Good for newcomers labels Mar 7, 2017
@morrme morrme mentioned this issue Mar 23, 2017
Merged
FridaTveit added a commit that referenced this issue Mar 24, 2017
@FridaTveit
Merge pull request #399 from morrme/patch-1
5402392 
Fixed issue #359
@FridaTveit
Copy link
Contributor

Fixed in PR #399 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtigger @FridaTveit